casaroli commented on code in PR #21001:
URL: https://github.com/apache/nuttx/pull/21001#discussion_r4398178616
##########
boards/arm/qemu/qemu-armv7a/scripts/dramboot.ld:
##########
@@ -113,7 +113,11 @@ SECTIONS
.bss : { /* BSS */
_sbss = .;
*(.bss*)
+#ifdef CONFIG_TLS_LOG2_MAXSTACK
Review Comment:
This fixes a board bug that is also on master without HRTIMER:
`qemu-armv7a:smp` sets `CONFIG_TLS_ALIGNED=y`, `CONFIG_TLS_LOG2_MAXSTACK`
defaults to 13, and `_ebss` is aligned to 4096 only. It is not part of the
hrtimer change (CONTRIBUTING 1.7.3, 1.7.4).
Fix: move this commit to a separate PR.
##########
Documentation/os/time/time_clock.rst:
##########
@@ -237,6 +237,17 @@ interesting OS event will occur, program the interval time
and
wait for it to fire. When the interval time fires, then the
scheduled activity is performed.
+HRTimer Options
Review Comment:
`CONFIG_TIMER_ADJUST_NSEC` is not only an HRTimer option:
`sched/Kconfig:133` is outside `if HRTIMER`, and `wd_adjust_next_tick()`
(`sched/wdog/wdog.h:170`) uses it in tickless builds without HRTIMER. The text
does not say that timers fire earlier, or that the option replaces
`CONFIG_TIMER_ADJUST_USEC` (in us). Also, this section is inside "Tickless OS",
but `CONFIG_HRTIMER_PRECISION_SHIFT` depends on `CONFIG_HRTIMER`.
Fix: move `CONFIG_HRTIMER_PRECISION_SHIFT` to "High-resolution Timer
Interfaces" and `CONFIG_TIMER_ADJUST_NSEC` to "Tickless Configuration Options".
Say that timers fire N ns earlier and that the option replaces
`CONFIG_TIMER_ADJUST_USEC`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
