Brijesh-Thakkar commented on PR #20996: URL: https://github.com/apache/nuttx/pull/20996#issuecomment-6526382091
@yf13 correction to my earlier comment: I measured it, and excluding AVR would be a regression, so please don't add that exclusion based on my note. Head 5c3a8e0 (commits 07c63f2, 0e1276e, 5c3a8e0 cherry-picked onto master 3122150b1f), avr-gcc 14.3.0, DEBUG_FULLOPT: | config | master | this PR as-is | AVR excluded | |---|---:|---:|---:| | breadxavr:nsh | 58485 | 58367 (-118) | 58485 (same as master) | | arduino-mega2560:nsh | 71462 | 71334 (-128) | 71468 (same code as master) | Even though __ultoa_invert still calls __udivdi3 on AVR (the div64_const path doesn't fully fold there), the PR still saves 118-128 B overall because the signed 64-bit division helpers (__divdi3/__moddi3) are no longer linked. That matches the MemBrowse -74 B on arduino-mega2560. so i guess we should avr enabled -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
