anchao commented on a change in pull request #1843:
URL: https://github.com/apache/incubator-nuttx/pull/1843#discussion_r491106203
##########
File path: tools/Config.mk
##########
@@ -458,7 +458,8 @@ define CLEAN
endef
else
define CLEAN
- $(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp
+ $(call DELFILE, $(wildcard $(foreach obj, $(OBJS), $(addsuffix /$(obj),
$(subst :, ,$(VPATH))))))
+ $(call DELFILE, *$(OBJEXT) *$(LIBEXT) *~ .*.swp)
Review comment:
Yes, I tried. Clean the *$(OBJEXT) is necessary ,the new logic will only
clear the objects with VPATH prefix. Removing the clean operation will cause
the objects in the nuttx repo to not be deleted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
