patacongo commented on a change in pull request #1843:
URL: https://github.com/apache/incubator-nuttx/pull/1843#discussion_r491473196
##########
File path: tools/Config.mk
##########
@@ -458,7 +458,8 @@ define CLEAN
endef
else
define CLEAN
- $(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp
+ $(call DELFILE, $(wildcard $(foreach obj, $(OBJS), $(addsuffix /$(obj),
$(subst :, ,$(VPATH))))))
+ $(call DELFILE, *$(OBJEXT) *$(LIBEXT) *~ .*.swp)
Review comment:
> An alternative is to have both *$(OBJEXT) and $(OBJS). That considers
both scenarios although there would be overlap between those two in some cases.
*$(OBJEXT) is not safe. What if it has no value? Catastrophe follows (this
has happened to me!)
There would be no overlap if if the wildcard based clean were done second.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
