casaroli commented on code in PR #21113:
URL: https://github.com/apache/nuttx/pull/21113#discussion_r4435075547
##########
drivers/serial/Kconfig:
##########
@@ -315,17 +315,6 @@ config SERIAL_TERMIOS
Note: other software settings (echo, \r\n<->\n, break, tcflush)
are always supported.
-config SERIAL_TXBULK
Review Comment:
This removes CONFIG_SERIAL_TXBULK, but
boards/risc-v/ab32vg1/ab32vg1-generic/configs/nsh/defconfig:133 and
configs/ostest/defconfig:82 still set it. The option disappears without a word
in the commit message, and savedefconfig drops the line, so these two
configurations no longer match their defconfig.
Fix: keep SERIAL_TXBULK (raiden00pl's size point), or remove
CONFIG_SERIAL_TXBULK=y from the two ab32vg1 defconfigs and say in the commit
message that the option is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
