speccy88 commented on PR #19224: URL: https://github.com/apache/nuttx/pull/19224#issuecomment-6590899597
Hi @casaroli @xiaoxiang781216, The remaining Linux (sim-01) failure is the apps repository-cleanliness check. CI reports the downloaded Berry source tree and ZIP archive as untracked after building and normalizing sim:berry. The companion fix is published in speccy88/nuttx-apps on branch fix/berry-ci-gitignore: https://github.com/speccy88/nuttx-apps/commit/e886da0e8eff12d2e4794daa81bbf8b9c6569b0a It adds only interpreters/berry/.gitignore: ```gitignore /berry/ /berry-*.zip ``` The commit includes my authorized Signed-off-by and an Assisted-by trailer. The connected GitHub integration returns HTTP 403 when creating a pull request against apache/nuttx-apps, so the upstream companion PR has not been created. Could a maintainer open/review the companion change from this branch, or apply the signed-off commit through the normal review process, then rerun #19224 against updated apps master? https://github.com/apache/nuttx-apps/compare/master...speccy88:fix/berry-ci-gitignore?expand=1 Additional validation: 13 targeted assertions passed using the original refresh_default cleanliness function from NuttX merge commit 78470ae3b4521ea6648bcb2119dcffdeb628fdc3. The test reproduces both untracked paths and failure before the change, then confirms a clean repository and passing check afterward. Tracked edits, new integration source files, unrelated archives, and unrelated NuttX changes still fail the check as intended. The root ignore rules and added file were verified against their Git blob hashes. git diff --check passes. This was an isolated cleanliness regression test with configuration refresh stubbed. No full firmware build or full GitHub CI rerun is claimed for this follow-up. Failing job: https://github.com/apache/nuttx/actions/runs/41436340663/job/125265534154 Thanks, Frederick -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
