casaroli commented on code in PR #19224: URL: https://github.com/apache/nuttx/pull/19224#discussion_r4448848972
########## boards/sim/sim/sim/configs/berry/defconfig: ########## @@ -0,0 +1,49 @@ +# +# This file is autogenerated: PLEASE DO NOT EDIT IT. +# +# You can use "make menuconfig" to make any modifications to the installed .config file. +# You can then do "make savedefconfig" to generate a new defconfig file that includes your +# modifications. +# +# CONFIG_NSH_CMDOPT_HEXDUMP is not set +CONFIG_ARCH="sim" +CONFIG_ARCH_BOARD="sim" +CONFIG_ARCH_BOARD_SIM=y +CONFIG_ARCH_CHIP="sim" +CONFIG_ARCH_SIM=y +CONFIG_BOARDCTL_POWEROFF=y +CONFIG_BOARD_LOOPSPERMSEC=0 +CONFIG_BOOT_RUNFROMEXTSRAM=y +CONFIG_BUILTIN=y +CONFIG_DEBUG_SYMBOLS=y +CONFIG_DEV_LOOP=y +CONFIG_ETC_FATDEVNO=2 +CONFIG_ETC_ROMFS=y +CONFIG_ETC_ROMFSDEVNO=1 +CONFIG_EXAMPLES_HELLO=y +CONFIG_FAT_LCNAMES=y +CONFIG_FAT_LFN=y +CONFIG_FS_BINFS=y +CONFIG_FS_FAT=y +CONFIG_FS_PROCFS=y +CONFIG_FS_ROMFS=y +CONFIG_IDLETHREAD_STACKSIZE=4096 +CONFIG_INIT_ENTRYPOINT="init_main" +CONFIG_INTERPRETERS_BERRY=y Review Comment: The sim-01 job fails on sim:berry: after the build, the apps tree has the untracked files `interpreters/berry/berry-4db341475df9e9ad18e6741ef978b4c467690e09.zip` and `interpreters/berry/berry/`, and the clean check of tools/testbuild.sh fails on them (job 125265534154, 4 attempts). nuttx-apps has no `interpreters/berry/.gitignore`, so after the merge the sim-01 job of every later PR fails too. Fix: add `interpreters/berry/.gitignore` with `/berry/` and `/berry-*.zip` to nuttx-apps (as `interpreters/lua/.gitignore` does), merge it first, then re-run this CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
