xiaoxiang781216 commented on code in PR #21456:
URL: https://github.com/apache/nuttx/pull/21456#discussion_r4471509031
##########
include/nuttx/compiler.h:
##########
@@ -199,6 +199,14 @@
# define CONFIG_HAVE_BUILTIN_FFSLL 1
# endif
+ /* An __asm__ label names the symbol with __USER_LABEL_PREFIX__ ("_" on
+ * RH850 and RX, empty on most targets).
+ */
+
+# define asm_symbol_str_(x) #x
+# define asm_symbol_str(x) asm_symbol_str_(x)
+# define asm_symbol(fn) asm_symbol_str(__USER_LABEL_PREFIX__) #fn
Review Comment:
let's use macro in nuttx/macro.h
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -290,6 +290,18 @@ RUN mkdir -p riscv-none-elf-gcc && \
curl -s -L
"https://github.com/xpack-dev-tools/riscv-none-elf-gcc-xpack/releases/download/v14.3.0-1/xpack-riscv-none-elf-gcc-14.3.0-1-linux-x64.tar.gz";
\
| tar -C riscv-none-elf-gcc --strip-components 1 -xz
+###############################################################################
Review Comment:
please split docker change to new pr, so we can merge it first and then
enable ci in this pr directly without error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
