parthitce commented on PR #21456: URL: https://github.com/apache/nuttx/pull/21456#issuecomment-6666248926
> Each arch has an `Arch:` and a `Board:` entry in `.github/labeler.yml` (`Arch: renesas`, `Arch: tricore`), but rh850 has none. A later PR on `arch/rh850/**` gets no arch label, so arch.yml takes "Allow the build" and starts every job. > > Fix: add `Arch: rh850` for `arch/rh850/**` and `Board: rh850` for `boards/rh850/**`. > > `install=` in `tools/ci/platforms/ubuntu.sh:434` has `rx_gcc_toolchain` but no RH850 entry, so a local `cibuild.sh` run on Ubuntu has no `v850-elf-gcc` for `/rh850`. > > Fix: add `rh850_gcc_toolchain` and `rh850_qemu` to ubuntu.sh as in linux.sh. > > Impact says "checked on sim and ARM, see Testing", but Testing has no such check. > > Fix: add the check and what it compared to Testing. Thanks for the quick review. Added the rh850 labels to labeler.yml. ubuntu.sh now installs the toolchain and QEMU, together with linux.sh and the Dockerfile in #21497. The compiler.h change moved to #21498, which has the sim and ARM before/after results in Testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
