xuxin930 opened a new pull request, #21712:
URL: https://github.com/apache/nuttx/pull/21712

     ## Summary
   
     This PR fixes several build system issues, mostly in the CMake build:
   
     - **tools/Make.defs**: Convert a relative `CONFIG_APPS_DIR` to an absolute 
path
       based on `TOPDIR`. `tools/Make.defs` is no longer always included from
       `TOPDIR`, so a relative path could not locate the apps `Make.defs`.
     - **include/sys/inotify.h**: Add `extern "C"` guards so C++ code that calls
       inotify APIs links against the C symbols instead of mangled names.
     - **syscall/wraps (CMake)**: Implement the missing `syscall_wraps.ldcmd`
       generation (previously a TODO) and pass it to the `nuttx` link via
       `@response-file`, matching the Makefile build.
     - **arch/arm clang (CMake)**: Apply `-Wa,-mthumb` and 
`-Wa,-mimplicit-it=always`
       to ASM sources only. Clang otherwise fails C files with
       `-Werror,-Wunused-command-line-argument`.
     - **nuttx_link_libraries**: Propagate the dependency's interface options,
       definitions and include directories as `PUBLIC`, so they are inherited
       transitively, and skip self-references.
   
     ## Impact
   
     - Build system only; no runtime behavior changes.
     - CMake builds with syscall wraps and ARM clang builds now succeed.
     - No change for absolute `CONFIG_APPS_DIR` values.
     - C++ users of `sys/inotify.h` link correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to