jingfei195887 commented on issue #20414: URL: https://github.com/apache/nuttx/issues/20414#issuecomment-6849322380
Hi @casaroli, thank you for the many fixes landing recently (signals, stdio streams, syslog, procfs). They close real POSIX gaps. While tracking footprint for this issue, I looked at how some of these changes affect small boards. MemBrowse flags them on its targets, so I built each PR's parent and merge commit on two STM32F103 configurations and compared the images (arm-none-eabi-gcc 10.3.1, `DEFAULT_SMALL=y`, Flash = text + data): | PR | `stm32f103-minimum:nsh` Flash / RAM | `nucleo-f103rb:nsh` Flash / RAM | |---|---:|---:| | #21128 syslog: `openlog()` / `closelog()` | +304 / +40 | +336 / +40 | | #21216 signal: keep the pending signals of each thread apart | +112 / 0 | +148 / 0 | | #21474 stream: fix crashes and overflows of `printf()` | +56 / 0 | +52 / 0 | | #21152 timer: queue one signal of a POSIX timer at a time | +56 / +32 | 0 / +32 | | #21507 stream: print floating point with integers | +16 / 0 | +16 / 0 | | #21682 fs: `st_ino` / `d_ino` / `st_dev` | +16 / 0 | 0 / 0 | | **Total** | **+560 / +72** | **+552 / +72** | Each one is small, and most of it buys correctness that is clearly worth having. Together it is about 1% of a ~52 KB image, which matters on 64 KB parts. I'd like to ask your opinion, since you know these areas best: for pieces that minimal systems rarely need, such as `openlog()`/`closelog()`, would you be open to making them optional, for example behind a Kconfig defaulting to `!DEFAULT_SMALL` like other footprint options? Or do you see a better way to keep this growth down? Happy to help with patches either way. cc @xiaoxiang781216 @acassis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
