bigcat-2026 commented on PR #21480: URL: https://github.com/apache/nuttx/pull/21480#issuecomment-6997345973
> The `check` job fails: commits "boards/esp32s3-r8: close SPIFLASH_FS choice with endchoice" and "esp32s3-r8: fix board build errors" have no Signed-off-by, and the board has no CMakeLists.txt for scripts/Make.defs and src/Make.defs. The board also has no page in Documentation/platforms/xtensa/esp32s3/boards/. Fix: squash the three commits into one with Signed-off-by, add the CMake files and a documentation page, and put the build and run logs of the configs in the Testing section. All feedback has been addressed. Could you please address this? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
