Ouss4 commented on a change in pull request #2061:
URL: https://github.com/apache/incubator-nuttx/pull/2061#discussion_r510375552
##########
File path: arch/arm/src/armv7-m/gnu/arm_exception.S
##########
@@ -321,9 +322,9 @@ exception_common:
.bss
.global g_intstackalloc
.global g_intstackbase
- .align 8
+ .balign 8
g_intstackalloc:
- .skip ((CONFIG_ARCH_INTERRUPTSTACK + 4) & ~7)
+ .skip (CONFIG_ARCH_INTERRUPTSTACK & ~7)
Review comment:
@xiaoxiang781216 why would that line be wrong? We use `INTERRUPTSTACK <
ALIGN_REQUIREMENT` to mean that there is no interrupt stack. We are not
changing `CONFIG_ARCH_INTERRUPTSTACK`.
But yes, when dumping the stack we always use the align down. Not sure why,
if we have a consistent INTSTACK_SIZE (whether aligned up or down) wouldn't
that suffice?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
