xiaoxiang781216 edited a comment on pull request #2061:
URL: https://github.com/apache/incubator-nuttx/pull/2061#issuecomment-715328711


   > @masayuki2009 @xiaoxiang781216
   > 
   > On the alignment please see the 
[86400a2](https://github.com/apache/incubator-nuttx/commit/86400a252dcbe6e4aef3ecca000b469a0fe96b67)
 and the blame. I think in this PR we are reverting a change that fixed a real 
problem.
   
   from the change, the stack space allocation round to the near(may roundup or 
rounddown), but the sp always point to the rounddown location. So I can't 
understand what problem he want to fix without the detail commit message. At 
least, the change isn't consistent with other related code(init sp and stack 
check).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to