[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2061: Refactor arm interrupt stack related code

[GitBox]

masayuki2009 commented on a change in pull request #2061:
URL: https://github.com/apache/incubator-nuttx/pull/2061#discussion_r511234827



##########
File path: arch/arm/src/armv7-a/arm_vectors.S
##########
@@ -261,7 +261,7 @@ arm_vectorirq:
        /* Call arm_decodeirq() on the interrupt stack */
 
        setirqstack r1, r3                              /* SP = IRQ stack top */
-       str             r0, [sp]                                /* Save the 
user stack pointer */
+       str             r0, [sp, #-8]!                  /* Save the xcp address 
at SP-8 then update SP */

Review comment:
       Yes
   

##########
File path: arch/arm/src/armv7-a/arm_vectors.S
##########
@@ -1004,7 +1004,7 @@ arm_vectorfiq:
 
 #if CONFIG_ARCH_INTERRUPTSTACK > 7
        setfiqstack r1, r4                              /* SP = FIQ stack top */
-       str             r0, [sp]                                /* Save the 
user stack pointer */
+       str             r0, [sp, #-8]!                  /* Save the xcp address 
at SP-8 then update SP */

Review comment:
       Yes
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org