Donny9 commented on a change in pull request #2158:
URL: https://github.com/apache/incubator-nuttx/pull/2158#discussion_r514160070



##########
File path: boards/sim/sim/sim/src/sim_bringup.c
##########
@@ -311,5 +316,15 @@ int sim_bringup(void)
     }
 #endif
 
+#ifdef CONFIG_SIM_LINUXI2CBUS
+  /* Initialize the i2c master via the Linux i2c bus device */
+
+  i2cbus = linuxi2c_initialize(9);

Review comment:
       This number of i2c bus shouldn't been hardcode. We should add config or 
a hardcode i2c path by soft link (/dev/i2c-x)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to