xiaoxiang781216 commented on a change in pull request #533:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/533#discussion_r546594247
##########
File path: interpreters/wamr/Makefile
##########
@@ -32,22 +42,25 @@ VPATH += $(WAMR_UNPACK)/product-mini/platforms/nuttx
MAINSRC = main.c
-PROGNAME = iwamr
+PROGNAME = iwasm
PRIORITY = $(CONFIG_INTERPRETERS_WAMR_PRIORITY)
STACKSIZE = $(CONFIG_INTERPRETERS_WAMR_STACKSIZE)
MODULE = $(CONFIG_INTERPRETERS_WAMR)
$(WAMR_TARBALL):
$(Q) echo "Downloading $(WAMR_TARBALL)"
- $(Q) wget $(WAMR_URL)
+ $(Q) curl -O -L $(WAMR_URL)
$(WAMR_UNPACK): $(WAMR_TARBALL)
$(Q) echo "Unpacking $(WAMR_TARBALL) to $(WAMR_UNPACK)"
- $(Q) tar xzvf $(WAMR_TARBALL)
- $(Q) mv wasm-micro-runtime-WAMR-$(WAMR_VERSION) $(WAMR_UNPACK)
+ $(Q) unzip $(WAMR_TARBALL)
+ $(Q) mv wasm-micro-runtime-$(WAMR_VERSION_STUB)$(WAMR_VERSION)
$(WAMR_UNPACK)
context:: $(WAMR_UNPACK)
+clean::
+ $(call DELDIR, $(WAMR_UNPACK))
+
Review comment:
Yes, clean should be removed.
##########
File path: interpreters/wamr/Makefile
##########
@@ -32,22 +42,25 @@ VPATH += $(WAMR_UNPACK)/product-mini/platforms/nuttx
MAINSRC = main.c
-PROGNAME = iwamr
+PROGNAME = iwasm
PRIORITY = $(CONFIG_INTERPRETERS_WAMR_PRIORITY)
STACKSIZE = $(CONFIG_INTERPRETERS_WAMR_STACKSIZE)
MODULE = $(CONFIG_INTERPRETERS_WAMR)
$(WAMR_TARBALL):
$(Q) echo "Downloading $(WAMR_TARBALL)"
- $(Q) wget $(WAMR_URL)
+ $(Q) curl -O -L $(WAMR_URL)
Review comment:
why switch to curl?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
