no1wudi commented on a change in pull request #533: URL: https://github.com/apache/incubator-nuttx-apps/pull/533#discussion_r546594382
########## File path: interpreters/wamr/Makefile ########## @@ -32,22 +42,25 @@ VPATH += $(WAMR_UNPACK)/product-mini/platforms/nuttx MAINSRC = main.c -PROGNAME = iwamr +PROGNAME = iwasm PRIORITY = $(CONFIG_INTERPRETERS_WAMR_PRIORITY) STACKSIZE = $(CONFIG_INTERPRETERS_WAMR_STACKSIZE) MODULE = $(CONFIG_INTERPRETERS_WAMR) $(WAMR_TARBALL): $(Q) echo "Downloading $(WAMR_TARBALL)" - $(Q) wget $(WAMR_URL) + $(Q) curl -O -L $(WAMR_URL) $(WAMR_UNPACK): $(WAMR_TARBALL) $(Q) echo "Unpacking $(WAMR_TARBALL) to $(WAMR_UNPACK)" - $(Q) tar xzvf $(WAMR_TARBALL) - $(Q) mv wasm-micro-runtime-WAMR-$(WAMR_VERSION) $(WAMR_UNPACK) + $(Q) unzip $(WAMR_TARBALL) + $(Q) mv wasm-micro-runtime-$(WAMR_VERSION_STUB)$(WAMR_VERSION) $(WAMR_UNPACK) context:: $(WAMR_UNPACK) +clean:: + $(call DELDIR, $(WAMR_UNPACK)) + Review comment: **WAMR_UNPACK** is the directory of unpacked context, but source tarball still here. If WAMR_VERSION changed in menuconfig, the correct source can be unpacked after `make clean`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org