gustavonihei commented on a change in pull request #2651:
URL: https://github.com/apache/incubator-nuttx/pull/2651#discussion_r570658149
##########
File path: arch/sim/src/Makefile
##########
@@ -318,9 +318,10 @@ nuttx$(EXEEXT): libarch$(LIBEXT) board/libboard$(LIBEXT)
$(LINKOBJS) $(HOSTOBJS)
sed -e '/====/,/====/!d;//d' -e 's/__executable_start/_stext/g' -e
's/__init_array_start/_sinit/g' \
-e 's/__init_array_end/_einit/g' -e
's/__fini_array_start/_sfini/g' -e 's/__fini_array_end/_efini/g' >nuttx.ld
$(Q) echo "__init_array_start = .; __init_array_end = .;
__fini_array_start = .; __fini_array_end = .;" >>nuttx.ld
+ $(eval _HOSTOBJS=$(filter-out libarch$(LIBEXT) board/libboard$(LIBEXT)
$(LINKOBJS) nuttx-names.dat, $^))
Review comment:
Could you explain the benefit of this change here? At first glance, the
need to filter-out the other requirements turns the solution much more
complicated than the current one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
