anchao commented on a change in pull request #2651:
URL: https://github.com/apache/incubator-nuttx/pull/2651#discussion_r574972064
##########
File path: arch/sim/src/Makefile
##########
@@ -318,9 +318,10 @@ nuttx$(EXEEXT): libarch$(LIBEXT) board/libboard$(LIBEXT)
$(LINKOBJS) $(HOSTOBJS)
sed -e '/====/,/====/!d;//d' -e 's/__executable_start/_stext/g' -e
's/__init_array_start/_sinit/g' \
-e 's/__init_array_end/_einit/g' -e
's/__fini_array_start/_sfini/g' -e 's/__fini_array_end/_efini/g' >nuttx.ld
$(Q) echo "__init_array_start = .; __init_array_end = .;
__fini_array_start = .; __fini_array_end = .;" >>nuttx.ld
+ $(eval _HOSTOBJS=$(filter-out libarch$(LIBEXT) board/libboard$(LIBEXT)
$(LINKOBJS) nuttx-names.dat, $^))
Review comment:
Hi,
sorry for the reply later.
The change here is actually for other reasons, The current NuttX compile
environment cannot be applied to the source files definition with
multi-directories.
You can refer to the discussion here:
https://github.com/apache/incubator-nuttx-apps/pull/395#issuecomment-694942015
Just consider adaptation of third-party external applications, the situation
is much more complicated than the nuttx scenario what we are using.
At present, there are two problems that bother us:
1. How to make multi-directories source files can correctly generate
dependencies
2. How to clean it
The current change is only a draft, and other related changes will be
submitted in the future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
