codebje commented on pull request #2861: URL: https://github.com/apache/incubator-nuttx/pull/2861#issuecomment-781314675
Having made these changes, I think `off_t` might be a good choice for `read` and `write` instead of `blkcnt_t`. It's frequently what the various read and write functions wind up using anyway. I also built an ARM variant to catch warnings and errors, so I found `lfs_size_t` and friends. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org