xiaoxiang781216 commented on pull request #2861: URL: https://github.com/apache/incubator-nuttx/pull/2861#issuecomment-781780800
@codebje the change looks good, but could you squash all commit into one? > I think the only remaining build failures are caused by `mkfatfs.c`, which needs format specifiers fixed in [apache/incubator-nuttx-apps#596](https://github.com/apache/incubator-nuttx-apps/pull/596). That PR itself has a build failure because it depends on the type change in `struct geometry`. I don't think I can make either one succeed independently, sorry. > > Well, perhaps I could use a cast to `unsigned long` in apps? Don't need, you just need mention the dependence in PR, maintainer will ignore the false alarm. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
