yamt commented on a change in pull request #3003:
URL: https://github.com/apache/incubator-nuttx/pull/3003#discussion_r590875068
##########
File path: arch/xtensa/src/esp32/esp32_allocateheap.c
##########
@@ -96,8 +96,15 @@ void xtensa_add_region(void)
{
size_t region2_start = HEAP_REGION2_START + XTENSA_IMEM_REGION_SIZE;
+#ifndef CONFIG_SMP
umm_addregion((FAR void *)region2_start,
(size_t)(uintptr_t)&_eheap - region2_start);
+#else
+ umm_addregion((FAR void *)region2_start,
+ (size_t)HEAP_REGION2_END - region2_start);
+ umm_addregion((FAR void *)HEAP_REGION3_START,
+ (size_t)&_eheap - HEAP_REGION3_START);
Review comment:
you can history-edit with git to make it cleaner if you want. but i'm
not sure if it's worth the effort. it's up to you.
my suggestion is do nothing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
