Ouss4 commented on a change in pull request #3003:
URL: https://github.com/apache/incubator-nuttx/pull/3003#discussion_r591644492



##########
File path: boards/xtensa/esp32/esp32-devkitc/scripts/esp32.template.ld
##########
@@ -50,7 +50,7 @@ MEMORY
    * be used.
    */
 
-  dram0_0_seg (RW) :     org = 0x3ffb0000 + CONFIG_ESP32_BT_RESERVE_DRAM,
+  dram0_0_seg (RW) :     org = 0x3ffae6f0 + CONFIG_ESP32_BT_RESERVE_DRAM,

Review comment:
       @yamt I dropped this commit.  I realised that when Bluetooth is enabled 
things will get complicated if we keep this region as static memory.
   Bluetooth uses a fixed region at the start of 0x3ffb0000, controlled by 
`CONFIG_ESP32_BT_RESERVER_DRAM` but it should be around 64KB, maybe a bit less.
   So I reverted the start of dram0_0_seg back to 0x3ffb0000 and used the 6KB 
region before that as heap, called REGION0, but open to better naming 
suggestions ;)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to