acassis commented on a change in pull request #3048:
URL: https://github.com/apache/incubator-nuttx/pull/3048#discussion_r593361260
##########
File path: arch/xtensa/src/esp32/esp32_tim.c
##########
@@ -252,13 +248,10 @@ static void esp32_tim_modifyreg32(FAR struct
esp32_tim_dev_s *dev,
*
****************************************************************************/
-static int esp32_tim_start(FAR struct esp32_tim_dev_s *dev)
+static void esp32_tim_start(FAR struct esp32_tim_dev_s *dev)
Review comment:
Why to change it to void? The timer API is expecting a value:
```
case TCIOC_START:
{
/* Start the timer, resetting the time to the current timeout */
if (lower->ops->start)
{
ret = lower->ops->start(lower);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
