saramonteiro commented on a change in pull request #3048: URL: https://github.com/apache/incubator-nuttx/pull/3048#discussion_r593392204
########## File path: arch/xtensa/src/esp32/esp32_tim.c ########## @@ -269,13 +262,10 @@ static int esp32_tim_start(FAR struct esp32_tim_dev_s *dev) * ****************************************************************************/ -static int esp32_tim_stop(FAR struct esp32_tim_dev_s *dev) +static void esp32_tim_stop(FAR struct esp32_tim_dev_s *dev) Review comment: Please, note that this stop is from lower half layer not from `esp32_tim.c`. The stop function from lower half is still returning int value. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org