xiaoxiang781216 commented on a change in pull request #92:
URL:
https://github.com/apache/incubator-nuttx-testing/pull/92#discussion_r605370143
##########
File path: testlist/avr.dat
##########
@@ -0,0 +1,6 @@
+# We do not have a toolchain for avr32 outside of Microchip login wall.
+# The work was never upstreamed to GCC.
+
+/avr
Review comment:
we have 10 config for avr, it's better to keep in other.dat too.
##########
File path: testlist/x86.dat
##########
@@ -0,0 +1,6 @@
+# x86_64-elf-gcc from homebrew doesn't seem to
+# provide __udivdi3 etc for -m32
+/x86
Review comment:
x86 just has two config, it's better to keep it in other.bat to save VM
setup time
##########
File path: testlist/x86.dat
##########
@@ -0,0 +1,6 @@
+# x86_64-elf-gcc from homebrew doesn't seem to
+# provide __udivdi3 etc for -m32
+/x86
+-Darwin,qemu-i486:.*
+
+/x86_64
Review comment:
ditto(x86_64 also has two config)
##########
File path: .github/workflows/build.yml
##########
@@ -24,7 +24,7 @@ jobs:
strategy:
matrix:
- boards: [arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07,
arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, other, sim]
+ boards: [arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07,
arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, avr, risc-v, xtensa, x86,
other, sim]
Review comment:
let's keep the alphabetical order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
