[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3632: [bp-3614]arch/risc-v: Fix stack alignment according to calling convention

[GitBox]

gustavonihei commented on a change in pull request #3632:
URL: https://github.com/apache/incubator-nuttx/pull/3632#discussion_r623011324



##########
File path: arch/risc-v/src/k210/k210_head.S
##########
@@ -215,17 +215,17 @@ normal_irq:
  *  Name: g_intstackalloc and g_intstackbase
  
************************************************************************************/
 
-#if CONFIG_ARCH_INTERRUPTSTACK > 7
+#if CONFIG_ARCH_INTERRUPTSTACK > 15
   .bss
-  .align  8
+  .align  16
   .global g_intstackalloc
   .global g_intstackbase
   .type   g_intstackalloc, object
   .type   g_intstackbase, object
 g_intstackalloc:

Review comment:
       Oh, the "recent refactoring" on @masayuki2009's PR might refer to this 
commit 3f67c67aaf from @xiaoxiang781216, which we also need to evaluate 
backporting it.
   It seems to be self-contained, not dependent on the big stack rework.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org