[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3632: [bp-3614]arch/risc-v: Fix stack alignment according to calling convention

Thu, 29 Apr 2021 10:28:21 -0700 


gustavonihei commented on a change in pull request #3632:
URL: https://github.com/apache/incubator-nuttx/pull/3632#discussion_r623252292



##########
File path: arch/risc-v/src/esp32c3/esp32c3_interrupt.S
##########
@@ -111,7 +111,7 @@ _interrupt_handler:
   csrr a0,  mcause    /* exception cause */
   mv   a1,  sp        /* context = sp */
 
-#if CONFIG_ARCH_INTERRUPTSTACK > 15
+#if CONFIG_ARCH_INTERRUPTSTACK > 3

Review comment:
       Nice finding, the current code from master is wrong.
   And I've found several other places where the interrupt stack is being 
handled with wrong alignment.
   I'll prepare a new PR for this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to