patacongo commented on a change in pull request #3626: URL: https://github.com/apache/incubator-nuttx/pull/3626#discussion_r623176905
########## File path: libs/libc/pthread/pthread_exit.c ########## @@ -0,0 +1,72 @@ +/**************************************************************************** + * libs/libc/pthread/pthread_exit.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <debug.h> +#include <sched.h> + +#include <nuttx/pthread.h> + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: pthread_exit + * + * Description: + * Terminate execution of a thread started with pthread_create. + * + * Input Parameters: + * exit_valie + * + * Returned Value: + * None + * + * Assumptions: + * + ****************************************************************************/ + +void pthread_exit(FAR void *exit_value) +{ Review comment: The long term objective is to move (almost) all of the pthread logic out of the OS and into the C library. That is the standard partitioning for example used in GNU/Linux: Linux implements implements basic native threading but it is GLIBC where all of the pthread interfaces are implemented. NuttX should follow this same partitioning. A key step to accomplishing that is to move all cancellation point logic into libs/libc/pthread. Many pthread APIs are very simple and just built on top of normal OS interfaces but cannot be moved into libs/libc/pthread because the current cancellation point logic works only in supervisor mode. Moving this to libs/libc/pthread would then enable moving almost all of the other pthread APIs there as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
