[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #3632: [bp-3614]arch/risc-v: Fix stack alignment according to calling convention

[GitBox]

Ouss4 commented on a change in pull request #3632:
URL: https://github.com/apache/incubator-nuttx/pull/3632#discussion_r623286055



##########
File path: arch/risc-v/src/esp32c3/esp32c3_interrupt.S
##########
@@ -111,7 +111,7 @@ _interrupt_handler:
   csrr a0,  mcause    /* exception cause */
   mv   a1,  sp        /* context = sp */
 
-#if CONFIG_ARCH_INTERRUPTSTACK > 15
+#if CONFIG_ARCH_INTERRUPTSTACK > 3

Review comment:
       Yes, but for what follows both 15 or 3 are not enough.  I personally 
used to read this as just "non empty" discarding any alignment.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org