RoCorbera commented on a change in pull request #743:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/743#discussion_r643089050
##########
File path: examples/leds/leds_main.c
##########
@@ -170,16 +197,25 @@ static int led_daemon(int argc, char *argv[])
goto errout_with_fd;
}
- usleep(500*1000L);
+ usleep(500 * 1000L);
+ }
+
+ /* treats signal termination of the task */
+
+ if (g_led_daemon_started == false)
+ {
+ /* task terminated by a SIGTERM */
+
+ exit(EXIT_SUCCESS);
}
-errout_with_fd:
- close(fd);
+ errout_with_fd:
+ close(fd);
-errout:
- g_led_daemon_started = false;
+ errout:
+ g_led_daemon_started = false;
Review comment:
In fact there were two odd error messages from checkpatch.sh.
One that related to the indentation of the very last "return" on lines
176-182.
The other saying that the path in line 2 (original source code) had to be
related to "/" as it was not a nuttx path (or something like that). The point
is that this error was related to a commentary block...
In order to fix I had to change the commentaries to the APACHE message...
even with a path, but after that the error was gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
