[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3836: Make: -nostartfiles -nodefaultlibs are not flags of LD but flags of GCC

[GitBox]

gustavonihei commented on a change in pull request #3836:
URL: https://github.com/apache/incubator-nuttx/pull/3836#discussion_r648242527



##########
File path: boards/arm/imxrt/imxrt1060-evk/scripts/Make.defs
##########
@@ -29,9 +29,9 @@ else ifeq ($(CONFIG_BOOT_RUNFROMISRAM),y)
 endif
 
 ifeq ($(CONFIG_CYGWIN_WINTOOL),y)
-  ARCHSCRIPT = -T "${shell cygpath -w 
$(BOARD_DIR)$(DELIM)scripts$(DELIM)$(LDSCRIPT)}"
+  ARCHSCRIPT = -Wl,-T "${shell cygpath -w 
$(BOARD_DIR)$(DELIM)scripts$(DELIM)$(LDSCRIPT)}"

Review comment:
       ```suggestion
     ARCHSCRIPT = -Wl,-T"${shell cygpath -w 
$(BOARD_DIR)$(DELIM)scripts$(DELIM)$(LDSCRIPT)}"
   ```
   We need to add commas where there were spaces to maintain the same behavior.
   There are more similar occurrences.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org