[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3836: Make: -nostartfiles -nodefaultlibs are not flags of LD but flags of GCC

[GitBox]

gustavonihei commented on a change in pull request #3836:
URL: https://github.com/apache/incubator-nuttx/pull/3836#discussion_r648250471



##########
File path: boards/arm/efm32/efm32-g8xx-stk/scripts/Make.defs
##########
@@ -51,8 +51,8 @@ CXXPICFLAGS = $(ARCHPICFLAGS) $(CXXFLAGS)
 CPPFLAGS := $(ARCHINCLUDES) $(ARCHDEFINES) $(EXTRAFLAGS)
 AFLAGS := $(CFLAGS) -D__ASSEMBLY__
 
-NXFLATLDFLAGS1 = -r -d -warn-common
-NXFLATLDFLAGS2 = $(NXFLATLDFLAGS1) 
-T$(TOPDIR)/binfmt/libnxflat/gnu-nxflat-pcrel.ld -no-check-sections
+NXFLATLDFLAGS1 = -r -Wl,-d -Wl,-warn-common
+NXFLATLDFLAGS2 = $(NXFLATLDFLAGS1) 
-T$(TOPDIR)/binfmt/libnxflat/gnu-nxflat-pcrel.ld -Wl,-no-check-sections

Review comment:
       
https://ftp.gnu.org/old-gnu/Manuals/ld-2.9.1/html_node/ld_3.html#:~:text=for%20options%20whose%20names%20are%20multiple%20letters%2C%20either%20one%20dash%20or%20two%20can%20precede%20the%20option%20name
   
   Yeah, LD accepts both ways.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org