yamt commented on a change in pull request #3992:
URL: https://github.com/apache/incubator-nuttx/pull/3992#discussion_r662109387



##########
File path: sched/group/group_create.c
##########
@@ -138,6 +139,9 @@ int group_allocate(FAR struct task_tcb_s *tcb, uint8_t 
ttype)
       return -ENOMEM;
     }
 
+  group->tg_info = (FAR struct task_info_s *)
+    group_zalloc(group, sizeof(struct task_info_s));

Review comment:
       
   > > i'm still not sure how this can work for CONFIG_BUILD_KERNEL. (i'm just 
asking here because i dunno.)
   > 
   > The whole path is a follow up #997 and no body report that #997 break the 
kernel build. Since #997 enter the mainline more than two years, I think the 
approach should work in KERNEL mode.
   
   i'm not saying it doesn't work. i just don't understand.
   specifically, i don't know how addenv and kumm allocator interacts.
   do you imply someone is actually running the kernel mode these days?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to