xiaoxiang781216 commented on a change in pull request #3992:
URL: https://github.com/apache/incubator-nuttx/pull/3992#discussion_r660636668
##########
File path: sched/group/group_create.c
##########
@@ -208,6 +212,28 @@ int group_allocate(FAR struct task_tcb_s *tcb, uint8_t
ttype)
return OK;
}
+/****************************************************************************
+ * Name: group_deallocate
+ *
+ * Description:
+ * Free a exist task group structure.
+ *
+ * Input Parameters:
+ * group = The group structure
+ *
+ ****************************************************************************/
+
+void group_deallocate(FAR struct task_group_s *group)
+{
+ DEBUGASSERT(group);
+ DEBUGASSERT(group->tg_info);
+
+ kumm_free(group->tg_info);
+ kmm_free(group);
+
+ return OK;
Review comment:
remove
##########
File path: libs/libc/tls/task_getinfo.c
##########
@@ -48,15 +49,7 @@
FAR struct task_info_s *task_get_info(void)
{
- FAR struct task_info_s *info = NULL;
- struct stackinfo_s stackinfo;
- int ret;
+ FAR struct tls_info_s *info = up_tls_info();
- ret = nxsched_get_stackinfo(-1, &stackinfo);
Review comment:
It's more clean why we remove -1 support in the same patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
