a-lunev commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677463503
##########
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##########
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to manage SDIO frames */
+struct __attribute__((packed)) bcmf_dma_buf
+{
+ uint8_t align_padding[CONFIG_IEEE80211_BROADCOM_SDIO_DMA_BUF_ALIGNMENT -
+ FIRST_WORD_SIZE];
+ uint8_t first_word[FIRST_WORD_SIZE];
+ uint8_t remaining_aligned_buf[HEADER_SIZE - FIRST_WORD_SIZE +
+ MAX_NETDEV_PKTSIZE + CONFIG_NET_GUARDSIZE];
+};
+
struct bcmf_sdio_frame
{
struct bcmf_frame_s header;
bool tx;
dq_entry_t list_entry;
- uint8_t data[HEADER_SIZE + MAX_NETDEV_PKTSIZE +
- CONFIG_NET_GUARDSIZE];
+ struct bcmf_dma_buf data
+ __attribute__((aligned(CONFIG_IEEE80211_BROADCOM_SDIO_DMA_BUF_ALIGNMENT)));
Review comment:
Hi @patacongo, good point. Thanks.
@xiaoxiang781216, initially I've misunderstood, I thought you've introduced
the aligned_data macro just today in #4238.
As the aligned_data macro is already in the master branch, now I've replaced
__attribute__((aligned(x))) by aligned_data(x).
Concerning compiler independence, now I've found "__attribute__((packed))"
occurrences in bcm43xxx driver.
Thus I've replaced "__attribute__((packed))" by "begin_packed_struct /
end_packed_struct" everywhere in bcm43xxx driver as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
