a-lunev commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677537261
##########
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##########
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to manage SDIO frames */
+struct __attribute__((packed)) bcmf_dma_buf
+{
+ uint8_t align_padding[CONFIG_IEEE80211_BROADCOM_SDIO_DMA_BUF_ALIGNMENT -
Review comment:
> It's more simple to attach aligned_data(16) to the data field directly:
In your example I need data[] buffer to be aligned to the boundary of 16 at
the offset of 4 (not at the offset of 0). Please, check my previous message.
And as I previously wrote, one more alternative approach would be to use a
monolitic data array (like in your example) and use offsets to point to
imaginary first_word[] and remaining_aligned_buf[] parts. Is the alternative
preferable?
##########
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##########
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to manage SDIO frames */
+struct __attribute__((packed)) bcmf_dma_buf
+{
+ uint8_t align_padding[CONFIG_IEEE80211_BROADCOM_SDIO_DMA_BUF_ALIGNMENT -
Review comment:
> It's more simple to attach aligned_data(16) to the data field directly:
In your example I need data[] buffer to be aligned to the boundary of 16 at
the offset of 4 (not at the offset of 0). Please, check my previous message.
And as I previously wrote, one more alternative approach would be to use a
monolitic data array (like in your example) and use offsets to point to
imaginary first_word[] and remaining_aligned_buf[] parts. Is the alternative
preferable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
