Ouss4 commented on pull request #4403:
URL: https://github.com/apache/incubator-nuttx/pull/4403#issuecomment-905075456


   @masayuki2009  Thanks for your comment, regarding:
   
   > Furthermore, in cxd56_serial.c case, I remember that up_txint() is called 
recursively. In this case, if we apply the driver-specific spinlock it would 
also cause a deadlock.
   
   I think this recursion is only there because of the SUPPRESS_SERIAL_INTS 
part, where I believe an else is missing.  In normal cases (where we don't 
suppress serial interrupts) we should just enable interrupts and leave.  This 
shouldn't recurse.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to