masayuki2009 commented on pull request #4403: URL: https://github.com/apache/incubator-nuttx/pull/4403#issuecomment-906920149
> @xiaoxiang781216 @masayuki2009 this is the snippet I'm taliking about: > > https://github.com/apache/incubator-nuttx/blob/bcce3314e5fa014cb747c6b219b19b99f2ea498a/arch/arm/src/cxd56xx/cxd56_serial.c#L998-L1007 > > I think an `#else` is missing at line 1001. This will avoid recusing `up_txint` when interrupts aren't suppressed. @Ouss4 As far as I tested with spresense:rndis_smp, I can not see any console outputs. ``` diff --git a/arch/arm/src/cxd56xx/cxd56_serial.c b/arch/arm/src/cxd56xx/cxd56_serial.c index 5ece1db4cc..243188293e 100644 --- a/arch/arm/src/cxd56xx/cxd56_serial.c +++ b/arch/arm/src/cxd56xx/cxd56_serial.c @@ -998,7 +998,7 @@ static void up_txint(FAR struct uart_dev_s *dev, bool enable) #ifndef CONFIG_SUPPRESS_SERIAL_INTS priv->ier |= UART_INTR_TX; up_serialout(priv, CXD56_UART_IMSC, priv->ier); - +#else /* Fake a TX interrupt here by just calling uart_xmitchars() with * interrupts disabled (note this may recurse). */ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
