[GitHub] [incubator-nuttx] anchao commented on pull request #4639: tcp_timer: eliminated false decrements of conn->timer in case of multiple network adapters.

[GitBox]

anchao commented on pull request #4639:
URL: https://github.com/apache/incubator-nuttx/pull/4639#issuecomment-939953021


   > @anchao I have added checks for the listed protocols as well.
   
   ```
   
------------------------------------------------------------------------------------
     Cleaning...
     Configuring...
     Disabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
     Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
     Building NuttX...
   can/can_poll.c: In function 'can_poll':
   Error: can/can_poll.c:64:3: error: implicit declaration of function 
'DEBUGASSERT' [-Werror=implicit-function-declaration]
      64 |   DEBUGASSERT(dev != NULL && conn != NULL && dev == conn->dev);
         |   ^~~~~~~~~~~
   ```
   
   There is a  build break that needs to be resolved, 
   
   ```
   diff --git a/net/can/can_poll.c b/net/can/can_poll.c
   index cf2b8dc70d..3caed22544 100644
   --- a/net/can/can_poll.c
   +++ b/net/can/can_poll.c
   @@ -26,6 +26,7 @@
    #include <nuttx/config.h>
    #if defined(CONFIG_NET) && defined(CONFIG_NET_CAN)
    
   +#include <assert.h>
    #include <debug.h>
    
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org