[GitHub] [incubator-nuttx] yamt commented on a change in pull request #4659: net/tcp(unbuffered): retransmit only one the earliest not acknowledged segment

[GitBox]

yamt commented on a change in pull request #4659:
URL: https://github.com/apache/incubator-nuttx/pull/4659#discussion_r727633309



##########
File path: net/tcp/tcp_send_unbuffered.c
##########
@@ -243,18 +243,54 @@ static uint16_t tcpsend_eventhandler(FAR struct 
net_driver_s *dev,
 
   else if ((flags & TCP_REXMIT) != 0)
     {
+#if defined(CONFIG_NET_TCP_SPLIT)
       /* Yes.. in this case, reset the number of bytes that have been sent
        * to the number of bytes that have been ACKed.
        */
 
       pstate->snd_sent = pstate->snd_acked;

Review comment:
       i meant, doesn't snd_acked here indicate "one the earliest not 
acknowledged segment"?
   i'm trying to understand why it actually "does a full rewind".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org