a-lunev commented on a change in pull request #4659:
URL: https://github.com/apache/incubator-nuttx/pull/4659#discussion_r727667843
##########
File path: net/tcp/tcp.h
##########
@@ -172,6 +172,9 @@ struct tcp_conn_s
uint8_t rcvseq[4]; /* The sequence number that we expect to
* receive next */
uint8_t sndseq[4]; /* The sequence number that was last sent by us */
+#if !defined(CONFIG_NET_TCP_SPLIT) && !defined(CONFIG_NET_TCP_WRITE_BUFFERS)
+ uint32_t rexmit_seq; /* The sequence number to be retrasmitted */
Review comment:
Previously I read your description in #4293 ("in some cases, we send tcp
segments with sequence numbers back and forth.
especially when sending an empty segment. (eg. pure ack, window updates)").
Thus I have added conn->rexmit_seq field that is used only for retrasmitting
a single TCP segment w/o a need to modify conn->sndseq each time and recovering
it back.
Thus I consider using conn->rexmit_seq as more reliable and stable way
rather than using conn->sndseq for retransmissions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
