patacongo commented on a change in pull request #4720:
URL: https://github.com/apache/incubator-nuttx/pull/4720#discussion_r735236998



##########
File path: fs/mqueue/mq_open.c
##########
@@ -165,7 +165,7 @@ static int file_mq_vopen(FAR struct file *mq, FAR const 
char *mq_name,
   FAR struct mqueue_inode_s *msgq;
   FAR struct mq_attr *attr = NULL;
   struct inode_search_s desc;
-  char fullpath[MAX_MQUEUE_PATH];

Review comment:
       > But, that change doesn't increase the stack usage with the default 
config?
   
   True, but the size is configurable and not bounded.  It would create a 
difficult to fix bug is a large value were configured.  Isn't it better to 
idiot-proof the code?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to