xiaoxiang781216 commented on a change in pull request #4720:
URL: https://github.com/apache/incubator-nuttx/pull/4720#discussion_r735248060
##########
File path: fs/mqueue/mq_open.c
##########
@@ -165,7 +165,7 @@ static int file_mq_vopen(FAR struct file *mq, FAR const
char *mq_name,
FAR struct mqueue_inode_s *msgq;
FAR struct mq_attr *attr = NULL;
struct inode_search_s desc;
- char fullpath[MAX_MQUEUE_PATH];
Review comment:
> The message queue implementation uses pre-allocated data as much as
possible for performance reasons; messaging operations must be very fast. But
this stack allocation is in fs_vopen(). I would not think that an allocation
while opening a named message queue would have any performance implication
since that is a rare event.
I concern not only the speed, but also the memory fragment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
