gustavonihei commented on a change in pull request #4716:
URL: https://github.com/apache/incubator-nuttx/pull/4716#discussion_r735986323
##########
File path: arch/sim/Kconfig
##########
@@ -127,15 +127,32 @@ config SIM_WALLTIME_SIGNAL
endchoice
+choice
+ prompt "Simulated Network Interface"
+ default SIM_NETNULL if !NET_ETHERNET
+ default SIM_NETDEV if NET_ETHERNET
+
+config SIM_NETNULL
+ bool "Simulated Network NULL Device"
+ ---help---
+ Simulated Network NULL Device.
Review comment:
`SIM_NETNULL` is not referenced anywhere. If I read correctly, this
seems to be just a dummy config for a non-existing device.
Instead, we could add `optional` keyword to this choice, which makes it
disabled by default.
https://github.com/apache/incubator-nuttx/blob/master/boards/xtensa/esp32/common/Kconfig#L25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
