gustavonihei commented on a change in pull request #4716:
URL: https://github.com/apache/incubator-nuttx/pull/4716#discussion_r736413303
##########
File path: arch/sim/Kconfig
##########
@@ -127,15 +127,26 @@ config SIM_WALLTIME_SIGNAL
endchoice
+choice
+ prompt "Simulated Network Interface"
+ default SIM_NETDEV if NET_ETHERNET
+
Review comment:
Well, it seems you agree that the proposed change is good.
If what's holding is the update of `sim` defconfigs, let's work this out.
Adding `optional` keyword just imposes a `CONFIG_SIM_NETDEV=y` in some
defconfigs where there is Network support.
In this case, I simply forced it on those defconfigs and used
`tools/refresh.sh` on the entire directory.
Here is a patch for it:
```patch
diff --git a/boards/sim/sim/sim/configs/libcxxtest/defconfig
b/boards/sim/sim/sim/configs/libcxxtest/defconfig
index 86a397f45f..b5954e7a7a 100644
--- a/boards/sim/sim/sim/configs/libcxxtest/defconfig
+++ b/boards/sim/sim/sim/configs/libcxxtest/defconfig
@@ -86,6 +86,7 @@ CONFIG_SCHED_HAVE_PARENT=y
CONFIG_SCHED_ONEXIT=y
CONFIG_SCHED_WAITPID=y
CONFIG_SDCLONE_DISABLE=y
+CONFIG_SIM_NETDEV=y
CONFIG_START_MONTH=6
CONFIG_START_YEAR=2008
CONFIG_STDIO_DISABLE_BUFFERING=y
diff --git a/boards/sim/sim/sim/configs/module/defconfig
b/boards/sim/sim/sim/configs/module/defconfig
index d1b44066ee..468ded86a8 100644
--- a/boards/sim/sim/sim/configs/module/defconfig
+++ b/boards/sim/sim/sim/configs/module/defconfig
@@ -69,6 +69,7 @@ CONFIG_SCHED_ONEXIT=y
CONFIG_SCHED_WAITPID=y
CONFIG_SDCLONE_DISABLE=y
CONFIG_SIG_DEFAULT=y
+CONFIG_SIM_NETDEV=y
CONFIG_START_MONTH=6
CONFIG_START_YEAR=2008
CONFIG_STDIO_DISABLE_BUFFERING=y
diff --git a/boards/sim/sim/sim/configs/module32/defconfig
b/boards/sim/sim/sim/configs/module32/defconfig
index 5e6d376f83..514e19a23f 100644
--- a/boards/sim/sim/sim/configs/module32/defconfig
+++ b/boards/sim/sim/sim/configs/module32/defconfig
@@ -69,6 +69,7 @@ CONFIG_SCHED_WAITPID=y
CONFIG_SDCLONE_DISABLE=y
CONFIG_SIG_DEFAULT=y
CONFIG_SIM_M32=y
+CONFIG_SIM_NETDEV=y
CONFIG_START_MONTH=6
CONFIG_START_YEAR=2008
CONFIG_STDIO_DISABLE_BUFFERING=y
diff --git a/boards/sim/sim/sim/configs/rpserver/defconfig
b/boards/sim/sim/sim/configs/rpserver/defconfig
index 311e40c986..bf6c33e43a 100644
--- a/boards/sim/sim/sim/configs/rpserver/defconfig
+++ b/boards/sim/sim/sim/configs/rpserver/defconfig
@@ -63,6 +63,7 @@ CONFIG_SCHED_HPWORK=y
CONFIG_SCHED_WAITPID=y
CONFIG_SIG_DEFAULT=y
CONFIG_SIM_M32=y
+CONFIG_SIM_NETDEV=y
CONFIG_SIM_NET_BRIDGE=y
CONFIG_SIM_RPTUN_MASTER=y
CONFIG_SYSLOG_PREFIX=y
diff --git a/boards/sim/sim/sim/configs/sotest/defconfig
b/boards/sim/sim/sim/configs/sotest/defconfig
index 938e129702..4c8d8ed7e3 100644
--- a/boards/sim/sim/sim/configs/sotest/defconfig
+++ b/boards/sim/sim/sim/configs/sotest/defconfig
@@ -68,6 +68,7 @@ CONFIG_SCHED_ONEXIT=y
CONFIG_SCHED_WAITPID=y
CONFIG_SDCLONE_DISABLE=y
CONFIG_SIG_DEFAULT=y
+CONFIG_SIM_NETDEV=y
CONFIG_START_MONTH=6
CONFIG_START_YEAR=2008
CONFIG_STDIO_DISABLE_BUFFERING=y
diff --git a/boards/sim/sim/sim/configs/sotest32/defconfig
b/boards/sim/sim/sim/configs/sotest32/defconfig
index df436747e0..607ccc3f5a 100644
--- a/boards/sim/sim/sim/configs/sotest32/defconfig
+++ b/boards/sim/sim/sim/configs/sotest32/defconfig
@@ -69,6 +69,7 @@ CONFIG_SCHED_WAITPID=y
CONFIG_SDCLONE_DISABLE=y
CONFIG_SIG_DEFAULT=y
CONFIG_SIM_M32=y
+CONFIG_SIM_NETDEV=y
CONFIG_START_MONTH=6
CONFIG_START_YEAR=2008
CONFIG_STDIO_DISABLE_BUFFERING=y
diff --git a/boards/sim/sim/sim/configs/vpnkit/defconfig
b/boards/sim/sim/sim/configs/vpnkit/defconfig
index 3f45b1cdaf..d82b8abfe8 100644
--- a/boards/sim/sim/sim/configs/vpnkit/defconfig
+++ b/boards/sim/sim/sim/configs/vpnkit/defconfig
@@ -81,6 +81,7 @@ CONFIG_SCHED_HAVE_PARENT=y
CONFIG_SCHED_ONEXIT=y
CONFIG_SCHED_WAITPID=y
CONFIG_SDCLONE_DISABLE=y
+CONFIG_SIM_NETDEV=y
CONFIG_SIM_NETDEV_VPNKIT=y
CONFIG_START_MONTH=6
CONFIG_START_YEAR=2008
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
