xiaoxiang781216 commented on pull request #4754: URL: https://github.com/apache/incubator-nuttx/pull/4754#issuecomment-955892159
> > > > It's better to apply the default compiler option to improve the compatibility > > > > > > > > > compatibility with what? > > > > > > 3rd party application, sorry I can't disclose the name publicly. > > what assumption does the app make? It assume wchar_t is four bytes and then has the enough space to encode UCS4 encoding. > > > The major reason to revert this patch is that it's wrong to make the different size of wchar_t between sim and real device(e.g. arm) as I list in the summary. > > how about using -fshort-wchar for arm then? short will make it's very hard to process surrogate pair(https://en.wikipedia.org/wiki/UTF-16) as I mention in the last reply. So I don't see there is any benefit to add the seldom used flag(-fshort-wchar), could you explain why you stick with this flag? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
