xiaoxiang781216 edited a comment on pull request #4754: URL: https://github.com/apache/incubator-nuttx/pull/4754#issuecomment-955949696
> > no standard mandates unicode or how it's implemented as far as i know. unicode is accepted by many countries as a standard to represent the character worldwide. If we want to support language other English, Unicode is the best option. > `__STDC_ISO_10646__` is optional. i feel it makes sense only if we are going to implement unicode wchar_t. are we? But if we want to support wchar_t, it's better to follow __STDC_ISO_10646__. > anyway, if we are going to revert this, don't forget to update this. > > https://github.com/apache/incubator-nuttx/blob/b58379b7380dcef3346bf9ff1ac76d40dc094095/include/sys/types.h#L170 Fix here: https://github.com/apache/incubator-nuttx/pull/4754/commits/339e54b62d81bcc8830218783d9a6d5fab141310 > > actually i don't insist. nuttx wchar_t has been 16 bit. (i don't know why.) i just haven't seen a good reason to change it, especially when the change increases memory usage. The size increasement should be small because: 1. The code which use wchar_t is very rare. 2. wchar_t is builtin type in C++ which mean it is already 4 bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
