pkarashchenko commented on a change in pull request #4908:
URL: https://github.com/apache/incubator-nuttx/pull/4908#discussion_r757899815
##########
File path: boards/arm/stm32h7/nucleo-h743zi/scripts/Make.defs
##########
@@ -22,7 +22,15 @@ include $(TOPDIR)/.config
include $(TOPDIR)/tools/Config.mk
include $(TOPDIR)/arch/arm/src/armv7-m/Toolchain.defs
-LDSCRIPT = flash.ld
+ifeq ($(CONFIG_APP_FORMAT_MCUBOOT),y)
+ifeq ($(CONFIG_USE_MCUBOOT_BOOTLOADER),y)
+ LDSCRIPT = flash-mcuboot-loader.ld
+else
+ LDSCRIPT = flash-mcuboot-app.ld
+endif
+else
+ LDSCRIPT = flash.ld
+endif
Review comment:
```suggestion
ifeq ($(CONFIG_APP_FORMAT_MCUBOOT),y)
ifeq ($(CONFIG_USE_MCUBOOT_BOOTLOADER),y)
LDSCRIPT = flash-mcuboot-loader.ld
else
LDSCRIPT = flash-mcuboot-app.ld
endif
else
LDSCRIPT = flash.ld
endif
```
##########
File path: boards/arm/stm32h7/nucleo-h743zi/Kconfig
##########
@@ -27,4 +27,66 @@ config STM32_ROMFS_IMAGEFILE
depends on STM32_ROMFS
default "../../../rom.img"
+
Review comment:
```suggestion
```
##########
File path: boards/arm/stm32h7/nucleo-h743zi/scripts/flash-mcu-loader.ld
##########
@@ -0,0 +1,200 @@
+/****************************************************************************
Review comment:
Please remove duplication.
boards/arm/stm32h7/nucleo-h743zi/scripts/flash-mcuboot-loader.ld is already
available
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
